Open
Conversation
also, minor fixes: linuxkm/lkcapi_aes_glue.c: in linuxkm_test_aescfb(), call the appropriate aes_cfb_test(), not aes_cfb_test(). linuxkm/lkcapi_glue.c: fix bugprone-macro-parentheses in REGISTER_ALG_OPTIONAL(). linuxkm/module_hooks.c: in updateFipsHash(), add suppression for clang-diagnostic-cast-function-type-strict warnings around actually-safe function pointer casts in call to wc_fips_generate_hash().
douzzer
requested review from
philljj,
sameehj,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10194
Scan targets checked: linuxkm-bugs, linuxkm-src
No new issues found in the changed files. ✅
Contributor
Author
|
retest this please |
Contributor
|
+1, I’d prefer a follow-up that extends linuxkm_test_aesccm / linuxkm_test_aesccm_rfc4309 with the same kind of end-to-end crypto_aead exercise linuxkm_test_aesgcm already does (wolfCrypt vectors plus crypto_alloc_aead / crypto_aead_encrypt / crypto_aead_decrypt), since aesccm_test() alone does not drive the shim the way the kernel does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linuxkm: implement LKCAPI shims for wolfCrypt-native AES-CCM.
also, minor fixes:
linuxkm/lkcapi_aes_glue.c: inlinuxkm_test_aescfb(), call the appropriateaes_cfb_test(), notaes_cfb_test().linuxkm/lkcapi_glue.c: fixbugprone-macro-parenthesesinREGISTER_ALG_OPTIONAL().linuxkm/module_hooks.c: inupdateFipsHash(), add suppression forclang-diagnostic-cast-function-type-strictwarnings around actually-safe function pointer casts in call towc_fips_generate_hash().tested with